Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use HW_PHYSMEM in get_total_system_memory_impl #628

Closed
wants to merge 3 commits into from
Closed

Use HW_PHYSMEM in get_total_system_memory_impl #628

wants to merge 3 commits into from

Conversation

rettakjak
Copy link
Contributor

@rettakjak
Use HW_PHYSMEM instead of HW_USERMEM in get_total_system_memory_impl
61636ad 
The code checked for sysctl being available and HW_PHYSMEM being
defined, but HW_USERMEM was actually being used with sysctl instead
of HW_PHYSMEM.

The case for OpenBSD, etc. use HW_PHYSMEM64 (which is obviously a
64-bit variant of HW_PHYSMEM) and the case for OSX uses HW_MEMSIZE
(which appears to be a 64-bit variant of HW_PHYSMEM).

Signed-off-by: Kris Katterjohn <katterjohn@gmail.com>
@rettakjak
Update and fix a couple of comments in meminfo.c
331130d 
This fixes a typo and also notes that HW_PHYSMEM64 is defined on
NetBSD (not just OpenBSD).

Signed-off-by: Kris Katterjohn <katterjohn@gmail.com>
@coveralls
Copy link

coveralls commented Jan 4, 2019 •
edited

Pull Request Test Coverage Report for Build 3583

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5770 unchanged lines in 27 files lost coverage.
  • Overall coverage increased (+0.7%) to 61.795%
Files with Coverage Reduction New Missed Lines %
src/feature/nodelist/routerlist.c 1 39.21%
src/feature/nodelist/nodelist.c 2 71.88%
src/core/or/versions.c 2 94.47%
src/feature/stats/rephist.c 2 40.49%
src/lib/time/tvdiff.c 3 90.0%
src/feature/dirparse/parsecommon.c 9 88.04%
src/lib/net/socketpair.c 11 65.33%
src/lib/err/backtrace.c 15 58.49%
src/ext/trunnel/trunnel.c 16 55.17%
src/lib/net/socket.c 19 53.09%
Totals Coverage Status
Change from base Build 3434: 0.7%
Covered Lines: 45288
Relevant Lines: 73288
💛 - Coveralls

@rettakjak
Add changes file for bug 28981
880d6a9 
The fix was in commit 61636ad.

Signed-off-by: Kris Katterjohn <katterjohn@gmail.com>
@ghost ghost closed this May 25, 2021
@ghost ghost deleted the branch torproject:master May 25, 2021 12:55
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@rettakjak @coveralls