Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket29040 #647

Merged
2 commits merged into from Feb 8, 2019
Merged

Ticket29040 #647

2 commits merged into from Feb 8, 2019

Conversation

ppopth
Copy link
Contributor

@ppopth ppopth commented Jan 15, 2019

No description provided.

@coveralls
Copy link

coveralls commented Jan 15, 2019

Pull Request Test Coverage Report for Build 3686

  • 0 of 3 (0.0%) changed or added relevant lines in 2 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.002%) to 61.745%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/app/config/config.c 0 1 0.0%
src/feature/hs/hs_client.c 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
src/feature/hs/hs_client.c 2 51.32%
src/app/config/config.c 3 72.5%
Totals Coverage Status
Change from base Build 3677: 0.002%
Covered Lines: 45260
Relevant Lines: 73302

💛 - Coveralls

We accidentally use `auth` after freeing it in
client_service_authorization_free. The way to solve it is to
free after using it.
We add an option param to safe_str and safe_str_client because in
some case we need to use those functions before global_options is set.
@ghost ghost merged commit 238a908 into torproject:master Feb 8, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants