Bug29960 cant fail #908
Merged
Bug29960 cant fail #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(These functions look pretty unified to me.) Part of 29660.
... and ed25519_public_to_base64(). Also remove all checks for the return values, which were redundant anyway, because the functions never failed. Part of 29960.
…64() And fix the documentation on the function: it does produce trailing "="s as padding. Also remove all checks for the return value, which were redundant anyway, because the function never failed. Part of 29660.
…64() Also remove all checks for the return value, which were redundant anyway, because the function never failed. Part of 29660.
base64_decode() does not require padding. Part of 29660.
Comment-only change. Part of 29660.
Pull Request Test Coverage Report for Build 4710
💛 - Coveralls |
nmathewson
reviewed
Apr 9, 2019
src/lib/crypt_ops/crypto_format.c
Outdated
| if (strlen(input) != ED25519_SIG_BASE64_LEN) | ||
| return -1; | ||
| char buf[ED25519_SIG_BASE64_LEN+3]; | ||
| char buf[ED25519_SIG_BASE64_LEN+1]; | ||
| memcpy(buf, input, ED25519_SIG_BASE64_LEN); |
There was a problem hiding this comment.
I think we don't need to use 'buf' here at all any more; we could just use "input" directly.
…e64() Part of 29960.
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.