Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a tor_abort_() wrapper in our util_bug.h macros #952

Merged
1 commit merged into from Aug 12, 2019

Conversation

nmathewson
Copy link
Contributor

Previously, our use of abort() would break anywhere that we didn't
include stdlib.h. This was especially troublesome in case where
tor_assert_nonfatal() was used with ALL_BUGS_ARE_FATAL, since that
one seldom gets tested.

As an alternative, we could have just made this header include
stdlib.h. But that seems bloaty.

Fixes bug 30189; bugfix on 0.3.4.1-alpha.

Previously, our use of abort() would break anywhere that we didn't
include stdlib.h.  This was especially troublesome in case where
tor_assert_nonfatal() was used with ALL_BUGS_ARE_FATAL, since that
one seldom gets tested.

As an alternative, we could have just made this header include
stdlib.h.  But that seems bloaty.

Fixes bug 30189; bugfix on 0.3.4.1-alpha.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4737

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 13 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.02%) to 60.301%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib/log/util_bug.c 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
src/feature/hs/hs_common.c 1 83.28%
src/feature/dirauth/shared_random.c 3 85.64%
src/feature/dirauth/dirvote.c 9 64.79%
Totals Coverage Status
Change from base Build 4665: -0.02%
Covered Lines: 42857
Relevant Lines: 71072

💛 - Coveralls

@ghost ghost merged commit 802ac8a into torproject:maint-0.3.5 Aug 12, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants