Make separate "Update & Settings" menu item

[micahflee]

This is related to #25 and #28. Rather than just making a new "Tor Browser Update" .desktop file that uses a -force-check-update flag, the menu item should use a -settings flag, and display a GUI interface that lets you do a couple things:

• Force an update check
• Toggle between preferring alpha or stable
• Launch TBB

This can be where all other settings we might want to add in the future can exist.

If it looks like this can get into deb.torproject.org soon, it might make more sense first to just finish #25 first, and add this later.

[Phoul]

It would also be helpful if the user had the ability to pick the Pluggable Transports Browser Bundle.

[micahflee]

Another option should be "Update over Tor".

[micahflee]

I've been working on this. Now if you run "torbrowser-launcher -settings", it looks like this. Though it doesn't actually save the settings yet.

[adrelanos]

Looks very well.

[ioerror]

Will those be checked by default?

[micahflee]

@ioerror, yes they will default to being checked. I've actually changed the text from "Check for and download updates over Tor" to "Download updates over Tor (recommended)".

I'm also considering adding another checkbox to address #41 that says something like "Download over hidden service", and that's only enabled if "Download updates over Tor" is checked. More thoughts on that in the other issue.

[adrelanos]

Some wishes for storing settings:

• If the options file has been deleted: use the internal defaults and rewrite that file.
• If one option is missing or invalid in options file: use the internal defaults.
• If half of the options is in there (because a new version of torbrowser-launcher introduced new settings): use the existing values, don't overwrite the old ones and add the new ones using internal defaults

[micahflee]

I just pushed a bunch of updates to this bug. There's now a settings dialogue and it has it's own menu item, and it saves your preferences. It's also now possible to choose if you want stable or alpha (though not yet Obfsproxy because of issues discussed in #38).

@adrelanos that's a good idea for choosing how to migrate the settings file. These recent commits include a settings file migration from 0.0.1 to 0.0.2, but I haven't thoroughly tested this migration yet.

I also haven't made it actually download anything over Tor yet, it just saves your setting there. And I also haven't yet added the Tor hidden service checkbox either (#41).

[adrelanos]

I think I found the holy grail for configuration files. .d-style configuration folders. In bash:

for i in /etc/tor-launcher.d/*; do
   if [ -f "$i" ]; then
      source "$i"
   fi
done

They get sourced in lexical order. Which means, you could have a /etc/tor-launcher.d/10_default and always add new comments and new default settings to that file. The user could use 20_user or 90_user and overrule any defaults you may have set. Dpkg (you) can replace the default configuration file and users can always overrule with what they want, or script/applications depending on your app can drop configurations.

If it's equally simple in Python, I recommend that way.

[legrostdg]

A more simple format for the configuration file(s) (.ini, yaml, ...) would be a plus, too.

[micahflee]

This issue (making a separate settings dialog) is already implemented and works, so I'm closing it. The issues for updating over Tor is #8 and using a hidden service is #41.