Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix opening new tab in already runned TBB #155

Merged
merged 1 commit into from
Dec 10, 2014
Merged

Fix opening new tab in already runned TBB #155

merged 1 commit into from
Dec 10, 2014

Conversation

komachi
Copy link
Contributor

@komachi komachi commented Dec 9, 2014

You should always pass -allow-remote. Otherwise new tab will work only if you pass some URL(s) on the first run.

@micahflee
Copy link
Collaborator

I noticed this after using for a bit -- thanks for the PR!

micahflee added a commit that referenced this pull request Dec 10, 2014
Fix opening new tab in already runned TBB
@micahflee micahflee merged commit dfcb27f into torproject:master Dec 10, 2014
@h01ger
Copy link
Contributor

h01ger commented Jan 25, 2015

I don't really understand this pull request:

but let me start from the beginning: so torbrowser-launcher 0.1.7 is in debian jessie currently, but 0.1.8 is needed for the new signing key. 0.1.8 looked suitable for jessie except for maybe de13483 which actually fixes this pull request #155 (according to the git commit message) - but then 0.1.9 came out, fixing that very commit with 3f1146e. so now i've build 0.1.9 locally with these two commits reverted and if i click on a link with middle mousebutton, it still opens in a new tab ?!?

This is on Debian, with iceweasel installed (but not running).

@komachi
Copy link
Contributor Author

komachi commented Jan 25, 2015

@h01ger It was not about middle mousebutton. Without this commit, if you run torbrowser-launcher and then torbrowser-launcher "https://github.com", you'll get popup says TBB already open. This commit fix it, so torbrowser-launcher "https://github.com" opens GitHub in a new tab of already launched TBB. The problem with -allow-remote in #157 is that if you have Firefox (not Iceweasel) installed, for some reason it opens tab in Firefox instead of TBB. It's a bug in upsteam. they should add some build flags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants