AppArmor updates for Tor Browser 9 #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, LD_LIBRARY_PATH is not passed to these processes, and then:
- Tor Browser cannot load libmozsandbox.so
- Tor Browser 9.0a6 does not start correctly:
/usr/lib/x86_64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.23' not
found (required by /usr/local/lib/tor-browser/libxul.so)
… while it should use its own copy of libstdc++.so.6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Here's the diff we had to apply in Tails to make Tor Browser 9 work under AppArmor confinement.
I did not test this with a more standard Tor Browser 9 setup yet but the changes don't seem risky to me.
I'd love if someone could review this (and ideally, test it).
Tor Browser 9.0 will be released on October 22. It would be sweet if torbrowser-launcher had a release ready for it earlier so the transition is seemless for users :)