This repository has been archived by the owner on Apr 19, 2023. It is now read-only.
Wrap javascript code in an array in Rack response #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`File.read` returns a String. String does not respond to `#each` and is therefore not a valid response body for a rack response. The Rack spec makes this clear: > The Body must respond to each and must only yield String values. The Body itself should not be an instance of String, as this will break in Ruby 1.9. This just wraps the resulting String in an Array, which is standard practice for this sort of thing.
|
The TorqueBox Project » torquebox #90 SUCCESS |
|
If you'd like me to add tests to this, I'd be glad to, I couldn't figure out where, if at all, this is tested. |
bbrowning
added a commit
that referenced
this pull request
Apr 12, 2013
Wrap javascript code in an array in Rack response
|
Thanks! |
|
Regarding tests, integration-tests/spec/browser_stomp_spec and integration-tests/spec/stomp_spec both use the integration test app integration-tests/apps/alacarte/stomp. That application does use the StompJavascriptClientProvider in it's config.ru. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: TORQUE-1081
File.readreturns a String. String does not respond to#eachand is therefore not a valid response body for a rack response. The Rack spec makes this clear:This just wraps the resulting String in an Array, which is standard practice for this sort of thing.