unable to install via librarian-pupppet

[sjama]

The module fails to install when using librarian-puppet. From the console output the problem seems to be emitting from the /spec/fixtures/modules directory.

I think the relative routes inside the manifests file is causing librarian-puppet to go in circular spin.

Consider reworking that directory, that should fix the issue.

[torrancew]

OK, at first glance I'm tempted to consider this a librarian-puppet bug, as this is (if I recall) the format that rspec-puppet lays out when you use it to generate tests for a module, and I haven't had issues installing it with r10k (a similar tool to librarian-puppet). Anyway, I'm willing to take a look and consider taking a different approach, but can you give me a bit of info first?

1. Are you using the git or puppetforge source when installing the module?
2. Could you share the specific error you get?

[sjama]

1. I was using the forge as my source but I have also just tested the git repo and I get the same error.
2. Here is the output from console

Error: Protocol error - ../../../../manifests or /var/puppet/.tmp/librarian/cache/source/puppet/forge/3792e516e3ff92a0ef9f5e827f8e76eb/torrancew/account/version/fbacc30a1f288ebf360ad2de66710082/account/spec/fixtures/modules/account/manifests

Error: Try 'puppet help module install' for usage

/opt/vagrant_ruby/lib/ruby/1.8/pathname.rb:1055:in `unlink'
:
Directory not empty - /var/puppet/.tmp/librarian/cache/source/puppet/forge/3792e516e3ff92a0ef9f5e827f8e76eb/torrancew/account/version/fbacc30a1f288ebf360ad2de66710082

3. You mentioned you are using rspec-puppet, I know rtyler is also using rspec-puppet for his Jenkins module and he does not have the same directory structure within spec

[torrancew]

Fair enough - I'll update both modules you filed bugs against this weekend, and cut fresh releases. It would still be good to file an issue upstream, as the @rodjek is the author of both rspec-puppet and librarian-puppet, and rspec-puppet's own "rspec-puppet-init" is what generated the format that librarian-puppet seems to have an issue with.

[sjama]

Wow. That was quick turnaround. I'll look forward to the new releases, I'm already using both modules locally and wanted to deploy them with librarian-puppet for production.

[torrancew]

At a second glance, the fix @rtyler uses may not work for me, as it looks like it's very dependent upon the layout of your development modules. I'm going to shim my rake tasks for releases, and fix what's on the forge. Git-based stuff may still be flakey for now, while I try to work with librarian-puppet upstream and figure out why this is broken.

[torrancew]

Version v0.0.3 uploaded to the forge and tagged as v0.0.3 in git.

[ghost]

Excellent. It works.