Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace lost puppetdoc for home_dir_perms #46

Merged
merged 1 commit into from
May 1, 2016

Conversation

rjw1
Copy link
Contributor

@rjw1 rjw1 commented May 5, 2015

The documentation for this variable was lost in e15b4e3

The documentation for this variable was lost in e15b4e3
@torrancew
Copy link
Owner

@rjw1 This feature is actually being deprecated, but I didn't want to break functionality just yet (I believe that was my intent, anyway -- you can see that $home_dir_perms param is no longer passed through). Would that represent a problem for you?

@rjw1
Copy link
Contributor Author

rjw1 commented Apr 30, 2016

I do actually use home_dir_perms.
I hadn't realised that the behaviour had changed in that commit as well.
To be honest a breaking change would have been better than an option that does nothing or at least a warning message if its set to something other than the default.
I actually pin to a commit in my Puppetfile anyway so probably wouldn't notice.

@torrancew
Copy link
Owner

Ok, I'll reverse course on that then, and restore functionality to that flag!

@rjw1
Copy link
Contributor Author

rjw1 commented May 1, 2016

Thanks 👍

@torrancew
Copy link
Owner

@rjw1 Opened #54 to track the regression. I'm going to close this out, as there's more work to be done here than just restoring the docstring. Should have this resolved in a day or two.

@torrancew torrancew closed this May 1, 2016
@torrancew
Copy link
Owner

Hmmm, I seem to have been on the wrong branch, docs seem to be the only missing piece here.

@torrancew torrancew reopened this May 1, 2016
@torrancew torrancew merged commit 08e5dcd into torrancew:develop May 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants