New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master branch up to php 7 compatibility #107

Merged
merged 2 commits into from Jan 12, 2017

Conversation

Projects
None yet
3 participants
@VasyOk
Contributor

VasyOk commented Jan 11, 2017

Поддержка php 7 в master-бранче для обеспечения работоспособности движка на свежих конфигурациях.

@Exileum Exileum changed the title from php 7 future to Master branch up to php 7 compatibility Jan 11, 2017

@Exileum Exileum self-requested a review Jan 11, 2017

@Exileum Exileum self-assigned this Jan 11, 2017

@Exileum Exileum added the Enhancement label Jan 11, 2017

@Exileum Exileum added this to the Версия 2.1.6 milestone Jan 11, 2017

Show outdated Hide outdated common.php
//

This comment has been minimized.

@Exileum

Exileum Jan 11, 2017

Member

Вообще это сторонняя библиотека, но да ладно, я так посмотрел там вообще обновлений не было 4 года.

@Exileum

Exileum Jan 11, 2017

Member

Вообще это сторонняя библиотека, но да ладно, я так посмотрел там вообще обновлений не было 4 года.

This comment has been minimized.

@VasyOk

VasyOk Jan 12, 2017

Contributor

по хорошему нужно переделать на подключение через бд.

@VasyOk

VasyOk Jan 12, 2017

Contributor

по хорошему нужно переделать на подключение через бд.

@@ -606,7 +606,7 @@ function bbcode2html ($text)
/**
* Clean up
*/
static function clean_up ($text)
static public function clean_up ($text)

This comment has been minimized.

@Exileum

Exileum Jan 11, 2017

Member

Нарушает PSR-2, должно быть public static, вот из документации:

Visibility MUST be declared on all properties and methods; abstract and final MUST be declared before the visibility; static MUST be declared after the visibility.

@Exileum

Exileum Jan 11, 2017

Member

Нарушает PSR-2, должно быть public static, вот из документации:

Visibility MUST be declared on all properties and methods; abstract and final MUST be declared before the visibility; static MUST be declared after the visibility.

This comment has been minimized.

@VasyOk

VasyOk Jan 12, 2017

Contributor

fixed

@VasyOk

VasyOk Jan 12, 2017

Contributor

fixed

}
$message = str_replace('\"', '"', substr(@preg_replace('#(\>(((?>([^><]+|(?R)))*)\<))#se', "@preg_replace(\$orig_word, \$replacement_word, '\\0')", '>' . $message . '<'), 1, -1));
$message = str_replace(

This comment has been minimized.

@Exileum

Exileum Jan 11, 2017

Member

Это круто прям 👍

@Exileum

Exileum Jan 11, 2017

Member

Это круто прям 👍

@Exileum

В принципе по мелочам поправить прокомментированное и можно сливать. Большое спасибо.

VasyOk added some commits Jan 11, 2017

@Exileum

Мелочь с public static и все ок 👌

@Exileum Exileum merged commit a04df19 into torrentpier:master Jan 12, 2017

0 of 2 checks passed

SensioLabsInsight Code quality below expectations.
Details
continuous-integration/styleci/pr The StyleCI analysis has failed - 34 files need addressing
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment