New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed compare version PHP #225

Merged
merged 1 commit into from Apr 6, 2017

Conversation

Projects
None yet
2 participants
@VasyOk
Contributor

VasyOk commented Apr 4, 2017

No description provided.

@VasyOk VasyOk requested a review from Exileum Apr 4, 2017

@VasyOk VasyOk self-assigned this Apr 4, 2017

@VasyOk VasyOk referenced this pull request Apr 4, 2017

Closed

Wrong PHP_VERSION check #224

@VasyOk VasyOk added this to the Версия 2.2.0 milestone Apr 4, 2017

@VasyOk VasyOk added the Bug label Apr 4, 2017

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Apr 4, 2017

Codecov Report

Merging #225 into develop will increase coverage by 10.02%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             develop     #225       +/-   ##
==============================================
+ Coverage      25.62%   35.65%   +10.02%     
+ Complexity       214      176       -38     
==============================================
  Files             25       16        -9     
  Lines            480      345      -135     
==============================================
  Hits             123      123               
+ Misses           357      222      -135
Impacted Files Coverage Δ Complexity Δ
src/Db/LogProcessor.php 0% <0%> (ø) 4% <0%> (ø) ⬇️
src/Db/Statement.php 0% <0%> (ø) 9% <0%> (ø) ⬇️
src/Db.php 0% <0%> (ø) 83% <0%> (ø) ⬇️
src/ServiceProviders/DbServiceProvider.php
src/ServiceProviders/TwigServiceProvider.php
src/ServiceProviders/CacheServiceProvider.php
src/ServiceProviders/SettingsServiceProvider.php
src/ServiceProviders/ConfigServiceProvider.php
src/ServiceProviders/LogServiceProvider.php
src/ServiceProviders/VisitorServiceProvider.php
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b44e86f...4f97abf. Read the comment docs.

codecov bot commented Apr 4, 2017

Codecov Report

Merging #225 into develop will increase coverage by 10.02%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             develop     #225       +/-   ##
==============================================
+ Coverage      25.62%   35.65%   +10.02%     
+ Complexity       214      176       -38     
==============================================
  Files             25       16        -9     
  Lines            480      345      -135     
==============================================
  Hits             123      123               
+ Misses           357      222      -135
Impacted Files Coverage Δ Complexity Δ
src/Db/LogProcessor.php 0% <0%> (ø) 4% <0%> (ø) ⬇️
src/Db/Statement.php 0% <0%> (ø) 9% <0%> (ø) ⬇️
src/Db.php 0% <0%> (ø) 83% <0%> (ø) ⬇️
src/ServiceProviders/DbServiceProvider.php
src/ServiceProviders/TwigServiceProvider.php
src/ServiceProviders/CacheServiceProvider.php
src/ServiceProviders/SettingsServiceProvider.php
src/ServiceProviders/ConfigServiceProvider.php
src/ServiceProviders/LogServiceProvider.php
src/ServiceProviders/VisitorServiceProvider.php
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b44e86f...4f97abf. Read the comment docs.

@Exileum Exileum changed the title from Fixed compare version PHP. to Fixed compare version PHP Apr 6, 2017

@Exileum

Exileum approved these changes Apr 6, 2017

@Exileum Exileum merged commit ec1f623 into torrentpier:develop Apr 6, 2017

10 checks passed

CodeFactor No issues found.
Details
Scrutinizer No new issues
Details
SensioLabsInsight Code quality OK.
Details
ci/circleci Your tests passed on CircleCI!
Details
codacy/pr Good work! A positive pull request.
Details
codecov/patch Coverage not affected when comparing b44e86f...4f97abf
Details
codecov/project 35.65% (+10.02%) compared to b44e86f
Details
continuous-integration/styleci/pr The StyleCI analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hound No violations found. Woof!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment