Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable new Axum implementation for the HTTP tracker #227

Closed
Tracked by #160
josecelano opened this issue Mar 9, 2023 · 0 comments · Fixed by #228
Closed
Tracked by #160

Enable new Axum implementation for the HTTP tracker #227

josecelano opened this issue Mar 9, 2023 · 0 comments · Fixed by #228

Comments

@josecelano
Copy link
Member

josecelano commented Mar 9, 2023

Parent issue: #160

We have finished the migration to Axum, but the setup.rs in the production code still runs the Warp version:

// Start the HTTP blocks
for http_tracker_config in &config.http_trackers {
    if !http_tracker_config.enabled {
        continue;
    }
    jobs.push(http_tracker::start_job(http_tracker_config, tracker.clone(), Version::Warp).await);
}

This issue enables the new Axum implementation:

// Start the HTTP blocks
for http_tracker_config in &config.http_trackers {
    if !http_tracker_config.enabled {
        continue;
    }
    jobs.push(http_tracker::start_job(http_tracker_config, tracker.clone(), Version::Axum).await);
}

After merging this change, the new Axum implementation will be used when you run the HTTP tracker.

josecelano added a commit to josecelano/torrust-tracker that referenced this issue Mar 9, 2023
@josecelano josecelano linked a pull request Mar 9, 2023 that will close this issue
josecelano added a commit that referenced this issue Mar 10, 2023
4355c2a feat: [#227] enable Axum HTTP tracker (Jose Celano)

Pull request description:

  Make the Axum HTTP tracker the implementations used in production code.

Top commit has no ACKs.

Tree-SHA512: 5e59f71c6dc9b30bb8b9643682ae91060b65705edf2ec70fdaa4a121a430ed0c322b5b33971e29c40a4e76fb86907efc6b7b008830250870811f986eadeeb68c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant