Skip to content

Commit

Permalink
Render loki datasources even if Grafana is disabled. (grafana#2197)
Browse files Browse the repository at this point in the history
I didn't realize but this was a perfect ok use case to generate datasource when using a different grafana deployment.

Fixes grafana#2186
Fixes grafana#2195

Now regarding grafana/loki#2086 it seems pretty easy to use `.Values.grafana.sidecar.datasources.enabled` if you don't want any datasources.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
  • Loading branch information
cyriltovena committed Jun 22, 2020
1 parent d75b5a2 commit 1912567
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion charts/loki-stack/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: "v1"
name: loki-stack
version: 0.38.0
version: 0.38.1
appVersion: v1.5.0
kubeVersion: "^1.10.0-0"
description: "Loki: like Prometheus, but for logs."
Expand Down
2 changes: 1 addition & 1 deletion charts/loki-stack/templates/datasources.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{- if and .Values.grafana.enabled .Values.grafana.sidecar.datasources.enabled }}
{{- if .Values.grafana.sidecar.datasources.enabled }}
apiVersion: v1
kind: ConfigMap
metadata:
Expand Down

0 comments on commit 1912567

Please sign in to comment.