Fixed: MySQL ssl option cast (#1163)

* Fixed: MySQL ssl option cast * Added: test and changelog entry for MySQL ssl option
tortoise · Jun 25, 2022 · 6e674f0 · 6e674f0
1 parent 5b3d8cc
commit 6e674f0
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -19,6 +19,7 @@ Fixed
 - `using_db` wrong position in model shortcut methods. (#1150)
 - Fixed connection to `Oracle` database by adding database info to DBQ in connection string.
 - Fixed ORA-01435 error while using `Oracle` database (#1155)
+- Fixed processing of `ssl` option in MySQL connection string.
 
 0.19.1
 ------

diff --git a/tests/backends/test_db_url.py b/tests/backends/test_db_url.py
@@ -311,7 +311,7 @@ def test_mysql_testing(self):
     def test_mysql_params(self):
         res = expand_db_url(
             "mysql://root:@127.0.0.1:3306/test?AHA=5&moo=yes&maxsize=20&minsize=5"
-            "&connect_timeout=1.5&echo=1"
+            "&connect_timeout=1.5&echo=1&ssl=True"
         )
         self.assertEqual(
             res,
@@ -331,6 +331,7 @@ def test_mysql_params(self):
                     "echo": True,
                     "charset": "utf8mb4",
                     "sql_mode": "STRICT_TRANS_TABLES",
+                    "ssl": True,
                 },
             },
         )

diff --git a/tortoise/backends/base/config_generator.py b/tortoise/backends/base/config_generator.py
@@ -82,6 +82,7 @@
             "no_delay": bool,
             "use_unicode": bool,
             "pool_recycle": int,
+            "ssl": bool,
         },
     },
     "mssql": {