Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Aerich into the install #530

Closed
enchance opened this issue Oct 23, 2020 · 3 comments · Fixed by #531
Closed

Integrate Aerich into the install #530

enchance opened this issue Oct 23, 2020 · 3 comments · Fixed by #531

Comments

@enchance
Copy link

enchance commented Oct 23, 2020

This is very minor seeing as the solution already exists but any plans of integrating Aerich into the install any time soon? Apparently some people I know are using alternatives like Gino because they're assuming Tortoise ORM has no migration feature.

Again, not an immediate feature request but helpful for new users.

FireShot Capture 090 - The integration of FastAPI and Django ORM __ map(learn, world) - kigawas me

The context here was that we were discussing porting Django's ORM to work with FastAPI, I think.

@long2ice
Copy link
Member

Yes, that's supportable, just need add aerich to tortoise requirements and update some docs. I will do it later. Thanks for your advice.

@enchance
Copy link
Author

Looking forward to the update man.

@K900
Copy link
Contributor

K900 commented Oct 24, 2020

I'd reconsider this - you're introducing a dependency cycle between aerich and tortoise-orm with no obvious way to break it. I'm all for advertising aerich more, but this is just making things difficult for package management tools for no obvious reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants