Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary cyclic dependency on Aerich in 0.16.17 #558

Closed
nckx opened this issue Nov 16, 2020 · 2 comments
Closed

Unnecessary cyclic dependency on Aerich in 0.16.17 #558

nckx opened this issue Nov 16, 2020 · 2 comments

Comments

@nckx
Copy link

nckx commented Nov 16, 2020

Hi,

Please consider reverting this new cyclic dependency on Aerich.

Tortoise-orm doesn't need Aerich at all: it simply wants to promote its existence. requirements.txt is the wrong place to do so and creates needless distribution headaches.

This is a documentation problem. The same commit also adds an excellent guide. Perhaps promoting it earlier in the README, before the tutorial, would help?

I say perhaps, because people ‘unaware’ of Aerich never bothered to read it.

Thanks!

@long2ice
Copy link
Member

Yes, cyclic dependency is a bad thing, I will revert that in next release.

@long2ice
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants