Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: aioodbc for mssql support #1102

Merged
merged 6 commits into from
Apr 13, 2022
Merged

WIP: aioodbc for mssql support #1102

merged 6 commits into from
Apr 13, 2022

Conversation

long2ice
Copy link
Member

@long2ice long2ice commented Apr 12, 2022

Description

Support MSSQL by aioodbc

Motivation and Context

How Has This Been Tested?

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added the changelog accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@long2ice long2ice marked this pull request as draft April 12, 2022 14:01
@coveralls
Copy link

coveralls commented Apr 12, 2022

Pull Request Test Coverage Report for Build 2158755302

  • 10 of 216 (4.63%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-3.04%) to 90.497%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tortoise/backends/mssql/init.py 0 2 0.0%
tortoise/backends/odbc/executor.py 0 11 0.0%
tortoise/backends/mssql/schema_generator.py 0 47 0.0%
tortoise/backends/mssql/client.py 0 69 0.0%
tortoise/backends/odbc/client.py 0 77 0.0%
Totals Coverage Status
Change from base Build 2158660100: -3.04%
Covered Lines: 5291
Relevant Lines: 5794

💛 - Coveralls

@long2ice long2ice marked this pull request as ready for review April 13, 2022 13:08
@long2ice long2ice merged commit 80fb191 into develop Apr 13, 2022
@long2ice long2ice deleted the odbc branch April 13, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants