Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix python3.11 testcase error & Allow ForeignKeyField(on_delete=NO_ACTION) #1410

Merged
merged 8 commits into from Jul 20, 2023
Merged

Fix python3.11 testcase error & Allow ForeignKeyField(on_delete=NO_ACTION) #1410

merged 8 commits into from Jul 20, 2023

Conversation

waketzheng
Copy link
Contributor

@waketzheng waketzheng commented Jun 25, 2023 •
edited

Description

  1. unittest.IsolatedAsyncioTestCase of Python3.11 use asyncio.Runner to run coroutines.
  2. unittest for mssql raises Introducing FOREIGN KEY constraint ... may cause cycles or multiple cascade paths. which requires ForeignKeyField(on_delete=NO_ACTION) to fix it

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added the changelog accordingly.
  • I have read the CONTRIBUTING document.
  • I have updated tests to cover my changes.
  • All new and existing tests passed.

@hyeongguen-song
Copy link
Contributor

Hi, @long2ice.
Would you check CI?
(I'm not sure. but) It doesn't seem to be affected by this fix

@waketzheng waketzheng changed the title Fix python3.11 testcase error Fix python3.11 testcase error & Allow ForeignKeyField(on_delete=NO_ACTION) Jul 17, 2023
@waketzheng
Copy link
Contributor Author

@long2ice Could you manually rerun the action, make ci succeed in my forked repo, but failed here.

@long2ice
Copy link
Member

OK

@waketzheng
Copy link
Contributor Author

@long2ice Codacy complaint fixed, but unittest need to manually rerun again.

@long2ice long2ice merged commit f6b3eb1 into tortoise:develop Jul 20, 2023
6 checks passed
@long2ice
Copy link
Member

Thanks!

esrehmki pushed a commit to esrehmki/tortoise-orm that referenced this pull request Aug 17, 2023
@waketzheng @long2ice @esrehmki
Fix python3.11 testcase error & Allow ForeignKeyField(on_delete=NO_AC…
e3ed789 
…TION) (tortoise#1410)

* ci: add python3.11

* fix: testcase error with python3.11 (tortoise#1308)

* Compare safe schema sql with github action result

* chore: add comment

* Allow ForeignKeyField(on_delete=NO_ACTION) (tortoise#1393)

* fix Codacy complaint

* Update pydantic example to use OnDelete Enum

---------

Co-authored-by: long2ice <long2ice@gmail.com>
@waketzheng waketzheng deleted the fix-python3.11-testcase-error branch August 25, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyeongguen-song hyeongguen-song hyeongguen-song approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@waketzheng @hyeongguen-song @long2ice