Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make get_annotations evaluate annotations in default scope #1609

Merged
merged 2 commits into from
May 10, 2024

Conversation

WizzyGeek
Copy link
Contributor

@WizzyGeek WizzyGeek commented May 9, 2024

Description

Might be a breaking change, evaluates the annotations in the default scope instead of app namespace.

Motivation and Context

Fixes #1552

How Has This Been Tested?

Tested by execution on an existing codebase.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added the changelog accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@WizzyGeek WizzyGeek marked this pull request as ready for review May 9, 2024 13:57
@WizzyGeek
Copy link
Contributor Author

@waketzheng Any changes needed?

@abondar abondar merged commit fe11aa5 into tortoise:develop May 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG:PEP563] tortoise.contrib.pydantic.utils.get_annotations uses incorrect global namespace
3 participants