Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run examples unittest #1644

Merged
merged 9 commits into from
Jun 12, 2024
Merged

Conversation

waketzheng
Copy link
Contributor

Description

.github/workflows/ci.yml

  1. make ci will auto install dependencies, so step that running make deps can be removed
  2. it is better to check example unittest in workflow
  3. newer version of coveralls have incorrent python version limit Upper limits are incorrect in requires-python TheKevJames/coveralls-python#449, so I add pip3 install --upgrade coveralls at line81

Makefile

Use _testall in ci to avoid install deps twice

poetry.lock

Auto update by make up

tests/

Just remove unused # noqa

Motivation and Context

How Has This Been Tested?

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added the changelog accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@coveralls
Copy link

coveralls commented Jun 11, 2024

Pull Request Test Coverage Report for Build 9461772527

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2845 unchanged lines in 60 files lost coverage.
  • Overall coverage decreased (-45.1%) to 42.753%

Files with Coverage Reduction New Missed Lines %
tortoise/backends/psycopg/schema_generator.py 1 83.33%
tortoise/manager.py 1 87.5%
tortoise/backends/mysql/init.py 2 0.0%
tortoise/backends/mssql/init.py 2 0.0%
tortoise/backends/oracle/init.py 2 0.0%
tortoise/backends/asyncpg/init.py 2 0.0%
tortoise/contrib/postgres/search.py 3 57.14%
tortoise/contrib/postgres/functions.py 3 69.23%
tortoise/exceptions.py 4 72.41%
tortoise/backends/oracle/executor.py 4 0.0%
Totals Coverage Status
Change from base Build 9345308446: -45.1%
Covered Lines: 2980
Relevant Lines: 6480

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 11, 2024

Pull Request Test Coverage Report for Build 9462264669

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2845 unchanged lines in 60 files lost coverage.
  • Overall coverage decreased (-45.1%) to 42.753%

Files with Coverage Reduction New Missed Lines %
tortoise/backends/psycopg/schema_generator.py 1 83.33%
tortoise/manager.py 1 87.5%
tortoise/backends/mysql/init.py 2 0.0%
tortoise/backends/mssql/init.py 2 0.0%
tortoise/backends/oracle/init.py 2 0.0%
tortoise/backends/asyncpg/init.py 2 0.0%
tortoise/contrib/postgres/search.py 3 57.14%
tortoise/contrib/postgres/functions.py 3 69.23%
tortoise/exceptions.py 4 72.41%
tortoise/backends/oracle/executor.py 4 0.0%
Totals Coverage Status
Change from base Build 9345308446: -45.1%
Covered Lines: 2980
Relevant Lines: 6480

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 11, 2024

Pull Request Test Coverage Report for Build 9462500601

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.004%) to 87.84%

Totals Coverage Status
Change from base Build 9345308446: -0.004%
Covered Lines: 5778
Relevant Lines: 6480

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 11, 2024

Pull Request Test Coverage Report for Build 9462909276

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.004%) to 87.84%

Totals Coverage Status
Change from base Build 9345308446: -0.004%
Covered Lines: 5778
Relevant Lines: 6480

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 11, 2024

Pull Request Test Coverage Report for Build 9463512915

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.1%) to 88.939%

Totals Coverage Status
Change from base Build 9345308446: 1.1%
Covered Lines: 5852
Relevant Lines: 6480

💛 - Coveralls

@abondar abondar merged commit edb5719 into tortoise:develop Jun 12, 2024
7 checks passed
@waketzheng waketzheng deleted the test-examples branch June 13, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants