Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Generate schema correctly with non-default column/table names. #166

Merged
merged 6 commits into from Aug 14, 2019
Merged

[WIP] Generate schema correctly with non-default column/table names. #166

merged 6 commits into from Aug 14, 2019

Conversation

grigi
Copy link
Member

@grigi grigi commented Aug 11, 2019 •
edited

Should fix #55

I was quite surprised at how hardcoded some of the field names were, especially with foreign keys.

  • Tests & fixes to generate schema with custom field/table names
  • Use this model to test basic functionality works as expected:
    • Save & Simple get_by_id
    • Search by indexed non-pk column
    • Forward foreign key
    • Backward foreign keys
    • Filter by foreign key values
    • M2M keys

@grigi grigi requested a review from abondar August 13, 2019 09:02
@grigi grigi mentioned this pull request Aug 13, 2019
Merged
@grigi grigi merged commit 006be72 into master Aug 14, 2019
@grigi grigi deleted the fix_source_field branch August 24, 2019 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abondar abondar abondar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ForeignKeyField with source_field argument
2 participants
@grigi @abondar