Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support await tortoise.contrib.fastapi.RegisterTortoise #1662

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

waketzheng
Copy link
Contributor

Description

  1. Run make style
  2. Update changelog
  3. Update RegisterTortoise class document
  4. Use typing.Self to improve type hint
  5. Support await for RegisterTortoise and add testcase for this feature

Motivation and Context

Sometimes, I want to use await RegiterTortoise(...) instead of async with RegiterTortoise(...)

How Has This Been Tested?

make ci

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added the changelog accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@abondar abondar merged commit b87f485 into tortoise:develop Jun 24, 2024
7 checks passed
@waketzheng waketzheng deleted the support-await-RegisterTortoise branch June 24, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants