Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct modification of FK field now persists #185

Merged
merged 6 commits into from Sep 6, 2019
Merged

Direct modification of FK field now persists #185

merged 6 commits into from Sep 6, 2019

Conversation

grigi
Copy link
Member

@grigi grigi commented Sep 6, 2019

Fixes #184

Done:

  • Assigning to the FK field will correctly set the associated db-field
  • Reading a nullalble FK field can now be None
  • Nullalble FK fields reverse-FK is now also nullable
  • Deleting a nullable FK field sets it to None

@coveralls
Copy link

coveralls commented Sep 6, 2019

Pull Request Test Coverage Report for Build 729

  • 14 of 14 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 97.511%

Totals Coverage Status
Change from base Build 718: 0.06%
Covered Lines: 2836
Relevant Lines: 2878

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 721

  • 10 of 10 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 97.534%

Totals Coverage Status
Change from base Build 718: 0.08%
Covered Lines: 2734
Relevant Lines: 2762

💛 - Coveralls

@grigi grigi merged commit e6870a2 into master Sep 6, 2019
@grigi grigi deleted the fix_null_fk branch September 24, 2019 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to use .save() method on a nullable ForeignKeyField
2 participants