-
-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect PydanticMeta::backward_relations #536
Conversation
Pull Request Test Coverage Report for Build 1872
💛 - Coveralls |
Pull Request Test Coverage Report for Build 432743649
💛 - Coveralls |
I hope this can be merged soon. It will solve my issue #510. |
decd06f
to
6b6b202
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but also need documentation changes
And please write down changes to CHANGELOG
Also you could add yourself to contributors file
Also implementing tests would be nice |
Thanks! |
6b6b202
to
3926a6c
Compare
3926a6c
to
57944aa
Compare
Implemented tests, updated CHANGELOG, added myself to CONTRIBUTORS. The class is mostly undocumented so I left docs as is. |
57944aa
to
5a3e4f8
Compare
5a3e4f8
to
50c353f
Compare
@abondar I think I've done everything. |
Thanks! |
@Hummer12007 released as 0.16.19 |
Description
Implemented
backward_relations
for PydanticMeta: if it is set toFalse
, fields of backward relationships will not be added to the Pydantic model.Motivation and Context
Specifying
backward_relations
has no effect with current versions of tortoise, even though it is mentioned in the docs.How Has This Been Tested?
Ran make test in the testing environment, will later add tests covering this feature.
Checklist:
My change requires a change to the documentation.I have updated the documentation accordingly.