Insert cleanup #54
Merged
Insert cleanup #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 240
💛 - Coveralls |
Pull Request Test Coverage Report for Build 214
💛 - Coveralls |
grigi
force-pushed
the
feature/prepared_statements
branch
from
20e948f
to
dbf7646
Compare
grigi
force-pushed
the
feature/prepared_statements
branch
from
235554f
to
c39b21c
Compare
abondar
approved these changes
Oct 16, 2018
tortoise/backends/base/executor.py
Outdated
| # Insert should implement returning new id to saved object | ||
| # Each db has it's own methods for it, so each implementation should | ||
| # go to descendant executors | ||
| raise NotImplementedError() # pragma: nocoverage | ||
|
|
||
| async def execute_insert(self, instance): | ||
| self.connection = await self.db.get_single_connection() | ||
| key = '%s:%s' % (self.db.connection_name, self.model._meta.table) |
There was a problem hiding this comment.
Does this kind of formatting gives any significant speedup?
If not, I think following .format() would be better, cause it feels really much more pythonic way
There was a problem hiding this comment.
Hmm, no idea.
I tend to use the % formatting over the .format() out of habit.
I just did a quick search, and, yep. that is the only such code in the codebase. I'll change it.
|
Yes, people get excited about performance 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch started with the goal of using prepared statements for inserts, but ended up being a general purpose insert/Client related cleanup.
Work done:
_prepare_insert_columnsand_prepare_insert_valuesnow do what they are calledexecute_insert()methodvaluesas a DB driver parameter (Building prepared statements kayak/pypika#163 is stalled, do something slightly hacky in the interm)(We need to try and get this into pypika, asasyncpgneeds prepared statements to perform well)Not related to inserts:
This should be the last performance-oriented PR from me for now, performance is up over double (and much more for sqlite)