Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Model context for DoesNotExit #742

Merged
merged 7 commits into from
Jun 3, 2024

Conversation

spacemanspiff2007
Copy link
Contributor

This provides the model as desired in #741.
What's missing is the primary key name and primary key value

How Has This Been Tested?

I ran only a small test locally

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@lqmanh
Copy link
Contributor

lqmanh commented Jun 2, 2021

@long2ice,
Is there any chance that this PR gets merged, or this feature is considered at least?

@abondar
Copy link
Member

abondar commented Jun 2, 2024

@spacemanspiff2007 Hi!

Sorry this PR didn't receive feedback
If by any chance you are still willing to implement it - I would be glad to review it

Although we would need to rebase it on current develop and initialise exception in same way for other places where this exception is used

@coveralls
Copy link

coveralls commented Jun 3, 2024

Pull Request Test Coverage Report for Build 9344979693

Details

  • 16 of 19 (84.21%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 87.844%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tortoise/exceptions.py 10 13 76.92%
Totals Coverage Status
Change from base Build 9340363157: -0.03%
Covered Lines: 5779
Relevant Lines: 6481

💛 - Coveralls

@spacemanspiff2007
Copy link
Contributor Author

Like this?

@abondar abondar merged commit f3e441e into tortoise:develop Jun 3, 2024
6 of 7 checks passed
@spacemanspiff2007 spacemanspiff2007 deleted the DoesNotExist_Context branch June 3, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants