Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ed25519 util #25

Merged
merged 2 commits into from
Apr 19, 2022

Conversation

mcgaryes
Copy link
Contributor

@mcgaryes mcgaryes commented Apr 9, 2022

Adds a convenience to create an ED25519 keypair with a user's torus key. I thought it would be better to add this functionality here in the torus-utils-swift project, that way it is capable of being used in both the CustomAuth and OpenLogin swift packages.

The only dependency that was brought in is the TweetNaCl Swift wrapper and original C library. If you would rather not have an additional dependency I can just bring that code into the repository and reference the original code base in the code.

The implementation is from the TweetNaCl website here https://tweetnacl.cr.yp.to/software.html.

I was also going to create two additional PRs in the CustomAuth and OpenLogin projects to update the required version of the TorusUtils and add examples of how to use the method to retrieve the keypair and use it to create a Solana Wallet.

If this isn't the right place for this functionality please let me know and I can move appropriately!

Copy link
Member

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcgaryes
Copy link
Contributor Author

@chaitanyapotti do you need me to look into why the checks failed?

@mcgaryes
Copy link
Contributor Author

Actually it looks like the run was just canceled.

@chaitanyapotti chaitanyapotti merged commit 90515b8 into torusresearch:master Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants