Skip to content

Commit

Permalink
mac80211_hwsim: fix possible memory leak in hwsim_new_radio_nl()
Browse files Browse the repository at this point in the history
'hwname' is malloced in hwsim_new_radio_nl() and should be freed
before leaving from the error handling cases, otherwise it will cause
memory leak.

Fixes: ff4dd73 ("mac80211_hwsim: check HWSIM_ATTR_RADIO_NAME length")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
  • Loading branch information
weiyongjun (A) authored and jmberg-intel committed Jan 22, 2018
1 parent 9cb05f9 commit 0ddcff4
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drivers/net/wireless/mac80211_hwsim.c
Expand Up @@ -3197,8 +3197,10 @@ static int hwsim_new_radio_nl(struct sk_buff *msg, struct genl_info *info)
if (info->attrs[HWSIM_ATTR_REG_CUSTOM_REG]) {
u32 idx = nla_get_u32(info->attrs[HWSIM_ATTR_REG_CUSTOM_REG]);

if (idx >= ARRAY_SIZE(hwsim_world_regdom_custom))
if (idx >= ARRAY_SIZE(hwsim_world_regdom_custom)) {
kfree(hwname);
return -EINVAL;
}
param.regd = hwsim_world_regdom_custom[idx];
}

Expand Down

0 comments on commit 0ddcff4

Please sign in to comment.