Skip to content

Commit

Permalink
caif: Fix missing msg_namelen update in caif_seqpkt_recvmsg()
Browse files Browse the repository at this point in the history
The current code does not fill the msg_name member in case it is set.
It also does not set the msg_namelen member to 0 and therefore makes
net/socket.c leak the local, uninitialized sockaddr_storage variable
to userland -- 128 bytes of kernel stack memory.

Fix that by simply setting msg_namelen to 0 as obviously nobody cared
about caif_seqpkt_recvmsg() not filling the msg_name in case it was
set.

Cc: Sjur Braendeland <sjur.brandeland@stericsson.com>
Signed-off-by: Mathias Krause <minipli@googlemail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
minipli authored and davem330 committed Apr 7, 2013
1 parent c8c4991 commit 2d6fbfe
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions net/caif/caif_socket.c
Expand Up @@ -286,6 +286,8 @@ static int caif_seqpkt_recvmsg(struct kiocb *iocb, struct socket *sock,
if (m->msg_flags&MSG_OOB) if (m->msg_flags&MSG_OOB)
goto read_error; goto read_error;


m->msg_namelen = 0;

skb = skb_recv_datagram(sk, flags, 0 , &ret); skb = skb_recv_datagram(sk, flags, 0 , &ret);
if (!skb) if (!skb)
goto read_error; goto read_error;
Expand Down

0 comments on commit 2d6fbfe

Please sign in to comment.