Skip to content

Commit

Permalink
gpiolib: Kill unused GPIOF_EXPORT and Co
Browse files Browse the repository at this point in the history
There is no use of the GPIOF_EXPORT in the kernel. Kill it for good.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
  • Loading branch information
andy-shev authored and Bartosz Golaszewski committed Jun 1, 2023
1 parent 6dd032b commit 2f804ac
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 20 deletions.
3 changes: 0 additions & 3 deletions Documentation/driver-api/gpio/legacy.rst
Original file line number Diff line number Diff line change
Expand Up @@ -322,9 +322,6 @@ where 'flags' is currently defined to specify the following properties:
* GPIOF_OPEN_DRAIN - gpio pin is open drain type.
* GPIOF_OPEN_SOURCE - gpio pin is open source type.

* GPIOF_EXPORT_DIR_FIXED - export gpio to sysfs, keep direction
* GPIOF_EXPORT_DIR_CHANGEABLE - also export, allow changing direction

since GPIOF_INIT_* are only valid when configured as output, so group valid
combinations as:

Expand Down
3 changes: 0 additions & 3 deletions Documentation/translations/zh_CN/driver-api/gpio/legacy.rst
Original file line number Diff line number Diff line change
Expand Up @@ -297,9 +297,6 @@ gpio_request()前将这类细节配置好,例如使用引脚控制子系统的
* GPIOF_OPEN_DRAIN - gpio引脚为开漏信号
* GPIOF_OPEN_SOURCE - gpio引脚为源极开路信号

* GPIOF_EXPORT_DIR_FIXED - 将 gpio 导出到 sysfs,并保持方向
* GPIOF_EXPORT_DIR_CHANGEABLE - 同样是导出, 但允许改变方向

因为 GPIOF_INIT_* 仅有在配置为输出的时候才存在,所以有效的组合为:

* GPIOF_IN - 配置为输入
Expand Down
3 changes: 0 additions & 3 deletions Documentation/translations/zh_TW/gpio.txt
Original file line number Diff line number Diff line change
Expand Up @@ -303,9 +303,6 @@ gpio_request()前將這類細節配置好,例如使用 pinctrl 子系統的映
* GPIOF_OPEN_DRAIN - gpio引腳爲開漏信號
* GPIOF_OPEN_SOURCE - gpio引腳爲源極開路信號

* GPIOF_EXPORT_DIR_FIXED - 將 gpio 導出到 sysfs,並保持方向
* GPIOF_EXPORT_DIR_CHANGEABLE - 同樣是導出, 但允許改變方向

因爲 GPIOF_INIT_* 僅有在配置爲輸出的時候才存在,所以有效的組合爲:

* GPIOF_IN - 配置爲輸入
Expand Down
6 changes: 0 additions & 6 deletions drivers/gpio/gpiolib-legacy.c
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,6 @@ int gpio_request_one(unsigned gpio, unsigned long flags, const char *label)
if (err)
goto free_gpio;

if (flags & GPIOF_EXPORT) {
err = gpiod_export(desc, flags & GPIOF_EXPORT_CHANGEABLE);
if (err)
goto free_gpio;
}

return 0;

free_gpio:
Expand Down
5 changes: 0 additions & 5 deletions include/linux/gpio.h
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,6 @@ struct device;
/* Gpio pin is open source */
#define GPIOF_OPEN_SOURCE (1 << 4)

#define GPIOF_EXPORT (1 << 5)
#define GPIOF_EXPORT_CHANGEABLE (1 << 6)
#define GPIOF_EXPORT_DIR_FIXED (GPIOF_EXPORT)
#define GPIOF_EXPORT_DIR_CHANGEABLE (GPIOF_EXPORT | GPIOF_EXPORT_CHANGEABLE)

/**
* struct gpio - a structure describing a GPIO with configuration
* @gpio: the GPIO number
Expand Down

0 comments on commit 2f804ac

Please sign in to comment.