Skip to content

Commit

Permalink
IB/qib: Fix duplicate sysfs directory name
Browse files Browse the repository at this point in the history
The qib driver load has been failing with the following message:

  sysfs: cannot create duplicate filename '/devices/pci0000:80/0000:80:02.0/0000:81:00.0/infiniband/qib0/ports/1/linkcontrol'

The patch below has two "linkcontrol" names causing the duplication.

Fix by using the correct "diag_counters" name on the second instance.

Fixes: 4a7aaf8 ("RDMA/qib: Use attributes for the port sysfs")
Link: https://lore.kernel.org/r/1645106372-23004-1-git-send-email-mike.marciniszyn@cornelisnetworks.com
Cc: <stable@vger.kernel.org>
Reviewed-by: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
Signed-off-by: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
  • Loading branch information
Mike Marciniszyn authored and jgunthorpe committed Feb 17, 2022
1 parent dfd42fa commit 32f57cb
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/infiniband/hw/qib/qib_sysfs.c
Expand Up @@ -541,7 +541,7 @@ static struct attribute *port_diagc_attributes[] = {
};

static const struct attribute_group port_diagc_group = {
.name = "linkcontrol",
.name = "diag_counters",
.attrs = port_diagc_attributes,
};

Expand Down

0 comments on commit 32f57cb

Please sign in to comment.