Skip to content

Commit

Permalink
w1_therm_read_bin: don't call flush_signals()
Browse files Browse the repository at this point in the history
This can disrupt userspace signal management.

Signed-off-by: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
Cc: Roland McGrath <roland@redhat.com>
Cc: Oleg Nesterov <oleg@tv-sign.ru>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Evgeniy Polyakov authored and Linus Torvalds committed Jun 28, 2007
1 parent a66e356 commit 33e44b1
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions drivers/w1/slaves/w1_therm.c
Expand Up @@ -191,11 +191,7 @@ static ssize_t w1_therm_read_bin(struct kobject *kobj, char *buf, loff_t off, si

w1_write_8(dev, W1_CONVERT_TEMP);

while (tm) {
tm = msleep_interruptible(tm);
if (signal_pending(current))
flush_signals(current);
}
msleep(tm);

if (!w1_reset_select_slave(sl)) {

Expand Down

0 comments on commit 33e44b1

Please sign in to comment.