Skip to content

Commit

Permalink
CRIS: Don't use mask_irq as symbol name
Browse files Browse the repository at this point in the history
kernel/irq/chip.c now uses these, which lead to compile error
for CRISv32.

Signed-off-by: Jesper Nilsson <jesper.nilsson@axis.com>
  • Loading branch information
jniax committed May 25, 2010
1 parent 392ed65 commit 4150764
Show file tree
Hide file tree
Showing 6 changed files with 21 additions and 22 deletions.
8 changes: 4 additions & 4 deletions arch/cris/arch-v10/kernel/irq.c
Expand Up @@ -17,8 +17,8 @@
#include <linux/kernel.h>
#include <linux/init.h>

#define mask_irq(irq_nr) (*R_VECT_MASK_CLR = 1 << (irq_nr));
#define unmask_irq(irq_nr) (*R_VECT_MASK_SET = 1 << (irq_nr));
#define crisv10_mask_irq(irq_nr) (*R_VECT_MASK_CLR = 1 << (irq_nr));
#define crisv10_unmask_irq(irq_nr) (*R_VECT_MASK_SET = 1 << (irq_nr));

/* don't use set_int_vector, it bypasses the linux interrupt handlers. it is
* global just so that the kernel gdb can use it.
Expand Down Expand Up @@ -116,12 +116,12 @@ static unsigned int startup_crisv10_irq(unsigned int irq)

static void enable_crisv10_irq(unsigned int irq)
{
unmask_irq(irq);
crisv10_unmask_irq(irq);
}

static void disable_crisv10_irq(unsigned int irq)
{
mask_irq(irq);
crisv10_mask_irq(irq);
}

static void ack_crisv10_irq(unsigned int irq)
Expand Down
4 changes: 2 additions & 2 deletions arch/cris/arch-v32/kernel/crisksyms.c
Expand Up @@ -24,5 +24,5 @@ EXPORT_SYMBOL(crisv32_io_get_name);
EXPORT_SYMBOL(crisv32_io_get);

/* Functions masking/unmasking interrupts */
EXPORT_SYMBOL(mask_irq);
EXPORT_SYMBOL(unmask_irq);
EXPORT_SYMBOL(crisv32_mask_irq);
EXPORT_SYMBOL(crisv32_unmask_irq);
14 changes: 6 additions & 8 deletions arch/cris/arch-v32/kernel/irq.c
Expand Up @@ -280,41 +280,39 @@ static int irq_cpu(int irq)
return cpu;
}

void
mask_irq(int irq)
void crisv32_mask_irq(int irq)
{
int cpu;

for (cpu = 0; cpu < NR_CPUS; cpu++)
block_irq(irq, cpu);
}

void
unmask_irq(int irq)
void crisv32_unmask_irq(int irq)
{
unblock_irq(irq, irq_cpu(irq));
}


static unsigned int startup_crisv32_irq(unsigned int irq)
{
unmask_irq(irq);
crisv32_unmask_irq(irq);
return 0;
}

static void shutdown_crisv32_irq(unsigned int irq)
{
mask_irq(irq);
crisv32_mask_irq(irq);
}

static void enable_crisv32_irq(unsigned int irq)
{
unmask_irq(irq);
crisv32_unmask_irq(irq);
}

static void disable_crisv32_irq(unsigned int irq)
{
mask_irq(irq);
crisv32_mask_irq(irq);
}

static void ack_crisv32_irq(unsigned int irq)
Expand Down
4 changes: 2 additions & 2 deletions arch/cris/arch-v32/kernel/smp.c
Expand Up @@ -168,8 +168,8 @@ void __init smp_callin(void)

/* Enable IRQ and idle */
REG_WR(intr_vect, irq_regs[cpu], rw_mask, vect_mask);
unmask_irq(IPI_INTR_VECT);
unmask_irq(TIMER0_INTR_VECT);
crisv32_unmask_irq(IPI_INTR_VECT);
crisv32_unmask_irq(TIMER0_INTR_VECT);
preempt_disable();
notify_cpu_starting(cpu);
local_irq_enable();
Expand Down
9 changes: 5 additions & 4 deletions arch/cris/include/arch-v10/arch/irq.h
Expand Up @@ -93,15 +93,16 @@ void set_break_vector(int n, irqvectptr addr);
"push $r10\n\t" /* push orig_r10 */ \
"clear.d [$sp=$sp-4]\n\t" /* frametype - this is a normal stackframe */

/* BLOCK_IRQ and UNBLOCK_IRQ do the same as mask_irq and unmask_irq */
/* BLOCK_IRQ and UNBLOCK_IRQ do the same as
* crisv10_mask_irq and crisv10_unmask_irq */

#define BLOCK_IRQ(mask,nr) \
"move.d " #mask ",$r0\n\t" \
"move.d $r0,[0xb00000d8]\n\t"
"move.d $r0,[0xb00000d8]\n\t"

#define UNBLOCK_IRQ(mask) \
"move.d " #mask ",$r0\n\t" \
"move.d $r0,[0xb00000dc]\n\t"
"move.d $r0,[0xb00000dc]\n\t"

#define IRQ_NAME2(nr) nr##_interrupt(void)
#define IRQ_NAME(nr) IRQ_NAME2(IRQ##nr)
Expand Down
4 changes: 2 additions & 2 deletions arch/cris/include/arch-v32/arch/irq.h
Expand Up @@ -23,8 +23,8 @@ struct etrax_interrupt_vector {

extern struct etrax_interrupt_vector *etrax_irv; /* head.S */

void mask_irq(int irq);
void unmask_irq(int irq);
void crisv32_mask_irq(int irq);
void crisv32_unmask_irq(int irq);

void set_exception_vector(int n, irqvectptr addr);

Expand Down

0 comments on commit 4150764

Please sign in to comment.