Skip to content

Commit

Permalink
sg_start_req(): make sure that there's not too many elements in iovec
Browse files Browse the repository at this point in the history
unfortunately, allowing an arbitrary 16bit value means a possibility of
overflow in the calculation of total number of pages in bio_map_user_iov() -
we rely on there being no more than PAGE_SIZE members of sum in the
first loop there.  If that sum wraps around, we end up allocating
too small array of pointers to pages and it's easy to overflow it in
the second loop.

X-Coverup: TINC (and there's no lumber cartel either)
Cc: stable@vger.kernel.org # way, way back
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
  • Loading branch information
Al Viro committed Apr 12, 2015
1 parent 8f7e885 commit 451a288
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions drivers/scsi/sg.c
Original file line number Diff line number Diff line change
Expand Up @@ -1744,6 +1744,9 @@ sg_start_req(Sg_request *srp, unsigned char *cmd)
md->from_user = 0;
}

if (unlikely(iov_count > MAX_UIOVEC))
return -EINVAL;

if (iov_count) {
int size = sizeof(struct iovec) * iov_count;
struct iovec *iov;
Expand Down

0 comments on commit 451a288

Please sign in to comment.