Skip to content

Commit 451a288

Browse files
author
Al Viro
committed
sg_start_req(): make sure that there's not too many elements in iovec
unfortunately, allowing an arbitrary 16bit value means a possibility of overflow in the calculation of total number of pages in bio_map_user_iov() - we rely on there being no more than PAGE_SIZE members of sum in the first loop there. If that sum wraps around, we end up allocating too small array of pointers to pages and it's easy to overflow it in the second loop. X-Coverup: TINC (and there's no lumber cartel either) Cc: stable@vger.kernel.org # way, way back Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
1 parent 8f7e885 commit 451a288

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

Diff for: drivers/scsi/sg.c

+3
Original file line numberDiff line numberDiff line change
@@ -1744,6 +1744,9 @@ sg_start_req(Sg_request *srp, unsigned char *cmd)
17441744
md->from_user = 0;
17451745
}
17461746

1747+
if (unlikely(iov_count > MAX_UIOVEC))
1748+
return -EINVAL;
1749+
17471750
if (iov_count) {
17481751
int size = sizeof(struct iovec) * iov_count;
17491752
struct iovec *iov;

0 commit comments

Comments
 (0)