Skip to content
Browse files

scsi: libsas: fix memory leak in sas_smp_get_phy_events()

We've got a memory leak with the following producer:

while true;
do cat /sys/class/sas_phy/phy-1:0:12/invalid_dword_count >/dev/null;

The buffer req is allocated and not freed after we return. Fix it.

Fixes: 2908d77 ("[SCSI] aic94xx: new driver")
Signed-off-by: Jason Yan <>
CC: John Garry <>
CC: chenqilin <>
CC: chenxiang <>
Reviewed-by: Christoph Hellwig <>
Reviewed-by: Hannes Reinecke <>
Signed-off-by: Martin K. Petersen <>
  • Loading branch information...
JasonYanHw authored and Martin K. Petersen committed Jan 4, 2018
1 parent f4d0ad1 commit 4a491b1ab11ca0556d2fda1ff1301e862a2d44c4
Showing with 1 addition and 0 deletions.
  1. +1 −0 drivers/scsi/libsas/sas_expander.c
@@ -695,6 +695,7 @@ int sas_smp_get_phy_events(struct sas_phy *phy)
phy->phy_reset_problem_count = scsi_to_u32(&resp[24]);

return res;

0 comments on commit 4a491b1

Please sign in to comment.
You can’t perform that action at this time.