Skip to content
Browse files

tun: allow positive return values on dev_get_valid_name() call

If the name argument of dev_get_valid_name() contains "%d", it will try
to assign it a unit number in __dev__alloc_name() and return either the
unit number (>= 0) or an error code (< 0).
Considering positive values as error values prevent tun device creations
relying this mechanism, therefor we should only consider negative values
as errors here.

Signed-off-by: Julien Gomes <>
Acked-by: Cong Wang <>
Signed-off-by: David S. Miller <>
  • Loading branch information...
gomesj authored and davem330 committed Oct 25, 2017
1 parent d309ae5 commit 5c25f65fd1e42685f7ccd80e0621829c105785d9
Showing with 1 addition and 1 deletion.
  1. +1 −1 drivers/net/tun.c
@@ -2028,7 +2028,7 @@ static int tun_set_iff(struct net *net, struct file *file, struct ifreq *ifr)
if (!dev)
return -ENOMEM;
err = dev_get_valid_name(net, dev, name);
if (err)
if (err < 0)
goto err_free_dev;

dev_net_set(dev, net);

0 comments on commit 5c25f65

Please sign in to comment.
You can’t perform that action at this time.