Skip to content

Commit

Permalink
dm cache metadata: fix cmd_read_lock() acquiring write lock
Browse files Browse the repository at this point in the history
Commit 9567366 ("dm cache metadata: fix READ_LOCK macros and
cleanup WRITE_LOCK macros") uses down_write() instead of down_read() in
cmd_read_lock(), yet up_read() is used to release the lock in
READ_UNLOCK().  Fix it.

Fixes: 9567366 ("dm cache metadata: fix READ_LOCK macros and cleanup WRITE_LOCK macros")
Cc: stable@vger.kernel.org
Signed-off-by: Ahmed Samy <f.fallen45@gmail.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
  • Loading branch information
asamy authored and snitm committed Apr 17, 2016
1 parent 9567366 commit 6545b60
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/md/dm-cache-metadata.c
Expand Up @@ -894,9 +894,9 @@ static bool cmd_write_lock(struct dm_cache_metadata *cmd)

static bool cmd_read_lock(struct dm_cache_metadata *cmd)
{
down_write(&cmd->root_lock);
down_read(&cmd->root_lock);
if (cmd->fail_io) {
up_write(&cmd->root_lock);
up_read(&cmd->root_lock);
return false;
}
return true;
Expand Down

0 comments on commit 6545b60

Please sign in to comment.