Skip to content

Commit

Permalink
[PATCH] NOHZ: Fix RCU handling
Browse files Browse the repository at this point in the history
When a CPU is needed for RCU the tick has to continue even when it was
stopped before.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Ingo Molnar authored and Linus Torvalds committed Feb 19, 2007
1 parent 2aa6eb3 commit 6ba9b34
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions kernel/time/tick-sched.c
Original file line number Diff line number Diff line change
Expand Up @@ -191,19 +191,19 @@ void tick_nohz_stop_sched_tick(void)
next_jiffies = get_next_timer_interrupt(last_jiffies);
delta_jiffies = next_jiffies - last_jiffies;

if (rcu_needs_cpu(cpu))
delta_jiffies = 1;
/*
* Do not stop the tick, if we are only one off
* or if the cpu is required for rcu
*/
if (!ts->tick_stopped && (delta_jiffies == 1 || rcu_needs_cpu(cpu)))
if (!ts->tick_stopped && delta_jiffies == 1)
goto out;

/* Schedule the tick, if we are at least one jiffie off */
if ((long)delta_jiffies >= 1) {

if (rcu_needs_cpu(cpu))
delta_jiffies = 1;
else
if (delta_jiffies > 1)
cpu_set(cpu, nohz_cpu_mask);
/*
* nohz_stop_sched_tick can be called several times before
Expand Down

0 comments on commit 6ba9b34

Please sign in to comment.