Skip to content

Commit

Permalink
mm/sparse.c: clean up obsolete code comment
Browse files Browse the repository at this point in the history
The code comment above sparse_add_one_section() is obsolete and incorrect.
Clean it up and write a new one.

Link: http://lkml.kernel.org/r/20190329144250.14315-1-bhe@redhat.com
Signed-off-by: Baoquan He <bhe@redhat.com>
Acked-by: Michal Hocko <mhocko@suse.com>
Reviewed-by: Oscar Salvador <osalvador@suse.de>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Reviewed-by: Mike Rapoport <rppt@linux.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Baoquan He authored and torvalds committed May 14, 2019
1 parent 926e5d1 commit 7567cfc
Showing 1 changed file with 12 additions and 4 deletions.
16 changes: 12 additions & 4 deletions mm/sparse.c
Expand Up @@ -684,10 +684,18 @@ static void free_map_bootmem(struct page *memmap)
#endif /* CONFIG_MEMORY_HOTREMOVE */
#endif /* CONFIG_SPARSEMEM_VMEMMAP */

/*
* returns the number of sections whose mem_maps were properly
* set. If this is <=0, then that means that the passed-in
* map was not consumed and must be freed.
/**
* sparse_add_one_section - add a memory section
* @nid: The node to add section on
* @start_pfn: start pfn of the memory range
* @altmap: device page map
*
* This is only intended for hotplug.
*
* Return:
* * 0 - On success.
* * -EEXIST - Section has been present.
* * -ENOMEM - Out of memory.
*/
int __meminit sparse_add_one_section(int nid, unsigned long start_pfn,
struct vmem_altmap *altmap)
Expand Down

0 comments on commit 7567cfc

Please sign in to comment.