Skip to content

Commit

Permalink
mptcp: use lockdep_assert_held_once() instead of open-coding it
Browse files Browse the repository at this point in the history
We have a few more places where the mptcp code duplicates
lockdep_assert_held_once(). Let's use the existing macro and
avoid a bunch of compiler's conditional.

Reviewed-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Paolo Abeni authored and davem330 committed Sep 25, 2021
1 parent 13ac17a commit 765ff42
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions net/mptcp/protocol.c
Expand Up @@ -956,9 +956,7 @@ static void __mptcp_update_wmem(struct sock *sk)
{
struct mptcp_sock *msk = mptcp_sk(sk);

#ifdef CONFIG_LOCKDEP
WARN_ON_ONCE(!lockdep_is_held(&sk->sk_lock.slock));
#endif
lockdep_assert_held_once(&sk->sk_lock.slock);

if (!msk->wmem_reserved)
return;
Expand Down Expand Up @@ -1117,9 +1115,8 @@ static void __mptcp_clean_una(struct sock *sk)

static void __mptcp_clean_una_wakeup(struct sock *sk)
{
#ifdef CONFIG_LOCKDEP
WARN_ON_ONCE(!lockdep_is_held(&sk->sk_lock.slock));
#endif
lockdep_assert_held_once(&sk->sk_lock.slock);

__mptcp_clean_una(sk);
mptcp_write_space(sk);
}
Expand Down

0 comments on commit 765ff42

Please sign in to comment.