Skip to content

Commit

Permalink
[squash] kbuild: add klpclean to PHONY
Browse files Browse the repository at this point in the history
Note: squash with ("kbuild: Support for Symbols.list creation")

The klpclean target doesn't generate a 'klpclean' file that could be
considered 'up to date', hence it is a PHONY target that should be run
every time it is requested.

A contrived example why this might be a problem: create a file of the
same name, then try to run 'make klpclean'.  Make sees the file and
considers it up to date, so the Symbols.list is never cleaned up.

  % touch klpclean
  % make klpclean
  make: 'klpclean' is up to date.
  % ls -l Symbols.list
  -rw-r--r--. 1 jolawren jolawren 2323179 Aug 29 16:55 Symbols.list

[joe: add klpclean to PHONY]

Signed-off-by: Joe Lawrence <joe.lawrence@redhat.com>
  • Loading branch information
joe-lawrence committed Mar 18, 2019
1 parent d8ac573 commit 7a8b0be
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -1352,7 +1352,7 @@ clean: rm-dirs := $(CLEAN_DIRS)
clean: rm-files := $(CLEAN_FILES)
clean-dirs := $(addprefix _clean_, . $(vmlinux-alldirs) Documentation samples)

PHONY += $(clean-dirs) clean archclean vmlinuxclean
PHONY += $(clean-dirs) clean archclean vmlinuxclean klpclean
$(clean-dirs):
$(Q)$(MAKE) $(clean)=$(patsubst _clean_%,%,$@)

Expand Down

0 comments on commit 7a8b0be

Please sign in to comment.