Skip to content

Commit

Permalink
HID: elo: fix memory leak in elo_probe
Browse files Browse the repository at this point in the history
When hid_parse() in elo_probe() fails, it forgets to call usb_put_dev to
decrease the refcount.

Fix this by adding usb_put_dev() in the error handling code of elo_probe().

Fixes: fbf4272 ("HID: elo: update the reference count of the usb device structure")
Reported-by: syzkaller <syzkaller@googlegroups.com>
Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
  • Loading branch information
mudongliang authored and Jiri Kosina committed Jan 24, 2022
1 parent e26a780 commit 817b8b9
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/hid/hid-elo.c
Expand Up @@ -262,6 +262,7 @@ static int elo_probe(struct hid_device *hdev, const struct hid_device_id *id)

return 0;
err_free:
usb_put_dev(udev);
kfree(priv);
return ret;
}
Expand Down

0 comments on commit 817b8b9

Please sign in to comment.