Skip to content

Commit

Permalink
virtio: update balloon size in balloon "probe"
Browse files Browse the repository at this point in the history
The following commit 'fad7b7b27b6a (virtio_balloon: Use a workqueue
instead of "vballoon" kthread)' has added a regression. Original code with
kthread starts the thread inside probe and checks the necessity to update
balloon inside the thread immediately.

Nowadays the code behaves differently. Work is queued only on the first
command from the host after the negotiation. Thus there is a window
especially at the guest startup or the module reloading when the balloon
size is not updated until the notification from the host.

This patch adds balloon size check at the end of the probe to match
original behaviour.

Signed-off-by: Konstantin Neumoin <kneumoin@virtuozzo.com>
Signed-off-by: Denis V. Lunev <den@openvz.org>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
  • Loading branch information
Konstantin Neumoin authored and mstsirkin committed Oct 30, 2016
1 parent 0ea1e4a commit 8424af5
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions drivers/virtio/virtio_balloon.c
Expand Up @@ -577,6 +577,8 @@ static int virtballoon_probe(struct virtio_device *vdev)

virtio_device_ready(vdev);

if (towards_target(vb))
virtballoon_changed(vdev);
return 0;

out_del_vqs:
Expand Down

0 comments on commit 8424af5

Please sign in to comment.