Skip to content

Commit

Permalink
cdrom: mark CDROMGETSPINDOWN/CDROMSETSPINDOWN obsolete
Browse files Browse the repository at this point in the history
These were only implemented by the IDE CD driver, which has since
been removed.  Given that nobody is likely to create new CD/DVD
hardware (and associated drivers) we can mark these appropriately.

Cc: Jens Axboe <axboe@kernel.dk>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Phillip Potter <phil@philpotter.co.uk>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Link: https://lore.kernel.org/all/20220427132436.12795-3-paul.gortmaker@windriver.com
Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
Link: https://lore.kernel.org/r/20220515205833.944139-4-phil@philpotter.co.uk
Signed-off-by: Jens Axboe <axboe@kernel.dk>
  • Loading branch information
paulgortmaker authored and axboe committed May 16, 2022
1 parent 03fea69 commit 8fa10ee
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
6 changes: 6 additions & 0 deletions Documentation/userspace-api/ioctl/cdrom.rst
Original file line number Diff line number Diff line change
Expand Up @@ -718,6 +718,9 @@ CDROMPLAYBLK


CDROMGETSPINDOWN
Obsolete, was ide-cd only


usage::

char spindown;
Expand All @@ -736,6 +739,9 @@ CDROMGETSPINDOWN


CDROMSETSPINDOWN
Obsolete, was ide-cd only


usage::

char spindown
Expand Down
2 changes: 1 addition & 1 deletion include/uapi/linux/cdrom.h
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@
#define CDROMREADALL 0x5318 /* read all 2646 bytes */

/*
* These ioctls are (now) only in ide-cd.c for controlling
* These ioctls were only in (now removed) ide-cd.c for controlling
* drive spindown time. They should be implemented in the
* Uniform driver, via generic packet commands, GPCMD_MODE_SELECT_10,
* GPCMD_MODE_SENSE_10 and the GPMODE_POWER_PAGE...
Expand Down

0 comments on commit 8fa10ee

Please sign in to comment.