Skip to content
Browse files

netlink: Fix dump skb leak/double free

When we free cb->skb after a dump, we do it after releasing the
lock.  This means that a new dump could have started in the time
being and we'll end up freeing their skb instead of ours.

This patch saves the skb and module before we unlock so we free
the right memory.

Fixes: 16b304f ("netlink: Eliminate kmalloc in netlink dump operation.")
Reported-by: Baozeng Ding <>
Signed-off-by: Herbert Xu <>
Acked-by: Cong Wang <>
Signed-off-by: David S. Miller <>
  • Loading branch information...
herbertx authored and davem330 committed May 16, 2016
1 parent 45e093a commit 92964c79b357efd980812c4de5c1fd2ec8bb5520
Showing with 5 additions and 2 deletions.
  1. +5 −2 net/netlink/af_netlink.c
@@ -2059,6 +2059,7 @@ static int netlink_dump(struct sock *sk)
struct netlink_callback *cb;
struct sk_buff *skb = NULL;
struct nlmsghdr *nlh;
struct module *module;
int len, err = -ENOBUFS;
int alloc_min_size;
int alloc_size;
@@ -2134,9 +2135,11 @@ static int netlink_dump(struct sock *sk)

nlk->cb_running = false;
module = cb->module;
skb = cb->skb;
return 0;


0 comments on commit 92964c7

Please sign in to comment.
You can’t perform that action at this time.