Skip to content

Commit

Permalink
lib/iov_iter: initialize "flags" in new pipe_buffer
Browse files Browse the repository at this point in the history
The functions copy_page_to_iter_pipe() and push_pipe() can both
allocate a new pipe_buffer, but the "flags" member initializer is
missing.

Fixes: 241699c ("new iov_iter flavour: pipe-backed")
To: Alexander Viro <viro@zeniv.linux.org.uk>
To: linux-fsdevel@vger.kernel.org
To: linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org
Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
  • Loading branch information
MaxKellermann authored and Al Viro committed Feb 21, 2022
1 parent e783362 commit 9d2231c
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions lib/iov_iter.c
Expand Up @@ -414,6 +414,7 @@ static size_t copy_page_to_iter_pipe(struct page *page, size_t offset, size_t by
return 0;

buf->ops = &page_cache_pipe_buf_ops;
buf->flags = 0;
get_page(page);
buf->page = page;
buf->offset = offset;
Expand Down Expand Up @@ -577,6 +578,7 @@ static size_t push_pipe(struct iov_iter *i, size_t size,
break;

buf->ops = &default_pipe_buf_ops;
buf->flags = 0;
buf->page = page;
buf->offset = 0;
buf->len = min_t(ssize_t, left, PAGE_SIZE);
Expand Down

0 comments on commit 9d2231c

Please sign in to comment.