Skip to content

Commit

Permalink
video: uvesafb: Fix integer overflow in allocation
Browse files Browse the repository at this point in the history
cmap->len can get close to INT_MAX/2, allowing for an integer overflow in
allocation. This uses kmalloc_array() instead to catch the condition.

Reported-by: Dr Silvio Cesare of InfoSect <silvio.cesare@gmail.com>
Fixes: 8bdb3a2 ("uvesafb: the driver core")
Cc: stable@vger.kernel.org
Signed-off-by: Kees Cook <keescook@chromium.org>
  • Loading branch information
kees committed Jun 12, 2018
1 parent 353748a commit 9f645bc
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion drivers/video/fbdev/uvesafb.c
Expand Up @@ -1044,7 +1044,8 @@ static int uvesafb_setcmap(struct fb_cmap *cmap, struct fb_info *info)
info->cmap.len || cmap->start < info->cmap.start)
return -EINVAL;

entries = kmalloc(sizeof(*entries) * cmap->len, GFP_KERNEL);
entries = kmalloc_array(cmap->len, sizeof(*entries),
GFP_KERNEL);
if (!entries)
return -ENOMEM;

Expand Down

0 comments on commit 9f645bc

Please sign in to comment.