Skip to content

Commit b8670c0

Browse files
kengiterdavem330
authored andcommitted
net: fix infoleak in llc
The stack object “info” has a total size of 12 bytes. Its last byte is padding which is not initialized and leaked via “put_cmsg”. Signed-off-by: Kangjie Lu <kjlu@gatech.edu> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 1c021bb commit b8670c0

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

Diff for: net/llc/af_llc.c

+1
Original file line numberDiff line numberDiff line change
@@ -626,6 +626,7 @@ static void llc_cmsg_rcv(struct msghdr *msg, struct sk_buff *skb)
626626
if (llc->cmsg_flags & LLC_CMSG_PKTINFO) {
627627
struct llc_pktinfo info;
628628

629+
memset(&info, 0, sizeof(info));
629630
info.lpi_ifindex = llc_sk(skb->sk)->dev->ifindex;
630631
llc_pdu_decode_dsap(skb, &info.lpi_sap);
631632
llc_pdu_decode_da(skb, info.lpi_mac);

0 commit comments

Comments
 (0)