Skip to content
Browse files

scsi: libsas: fix a race condition when smp task timeout

When the lldd is processing the complete sas task in interrupt and set the
task stat as SAS_TASK_STATE_DONE, the smp timeout timer is able to be
triggered at the same time. And smp_task_timedout() will complete the task
wheter the SAS_TASK_STATE_DONE is set or not. Then the sas task may freed
before lldd end the interrupt process. Thus a use-after-free will happen.

Fix this by calling the complete() only when SAS_TASK_STATE_DONE is not
set. And remove the check of the return value of the del_timer(). Once the
LLDD sets DONE, it must call task->done(), which will call
smp_task_done()->complete() and the task will be completed and freed

Reported-by: chenxiang <>
Signed-off-by: Jason Yan <>
CC: John Garry <>
CC: Johannes Thumshirn <>
CC: Ewan Milne <>
CC: Christoph Hellwig <>
CC: Tomas Henzl <>
CC: Dan Williams <>
CC: Hannes Reinecke <>
Reviewed-by: Hannes Reinecke <>
Reviewed-by: John Garry <>
Reviewed-by: Johannes Thumshirn <>
Signed-off-by: Martin K. Petersen <>
  • Loading branch information...
JasonYanHw authored and Martin K. Petersen committed Sep 25, 2018
1 parent 437207d commit b90cd6f2b905905fb42671009dc0e27c310a16ae
Showing with 4 additions and 5 deletions.
  1. +4 −5 drivers/scsi/libsas/sas_expander.c
@@ -48,17 +48,16 @@ static void smp_task_timedout(struct timer_list *t)
unsigned long flags;

spin_lock_irqsave(&task->task_state_lock, flags);
if (!(task->task_state_flags & SAS_TASK_STATE_DONE))
if (!(task->task_state_flags & SAS_TASK_STATE_DONE)) {
task->task_state_flags |= SAS_TASK_STATE_ABORTED;
spin_unlock_irqrestore(&task->task_state_lock, flags);


static void smp_task_done(struct sas_task *task)
if (!del_timer(&task->slow_task->timer))

0 comments on commit b90cd6f

Please sign in to comment.
You can’t perform that action at this time.